Cosmetics

Rename variable keys_pages to keysPages.
Rename variable page_index to pageIndex.
Rename textarea text to keyboardtext.
Rename button textkeysbutton to keyboardkeysbutton.
Omit last , in array.
This commit is contained in:
Unrud 2022-01-27 16:50:08 +01:00
parent a113b3adb7
commit 24f3eb63ec
3 changed files with 28 additions and 28 deletions

File diff suppressed because one or more lines are too long

View file

@ -313,7 +313,7 @@ function handleKeydown(evt) {
"Up": KEY_UP, "Up": KEY_UP,
"ArrowUp": KEY_UP, "ArrowUp": KEY_UP,
"Down": KEY_DOWN, "Down": KEY_DOWN,
"ArrowDown": KEY_DOWN, "ArrowDown": KEY_DOWN
}[evt.key]; }[evt.key];
if (key != undefined) { if (key != undefined) {
evt.preventDefault(); evt.preventDefault();
@ -338,10 +338,10 @@ window.addEventListener("load", function() {
pad = document.getElementById("pad"); pad = document.getElementById("pad");
padlabel = document.getElementById("padlabel"); padlabel = document.getElementById("padlabel");
var keys = document.getElementById("keys"); var keys = document.getElementById("keys");
var keys_pages = keys.querySelectorAll(".page"); var keysPages = keys.querySelectorAll(".page");
var keyboard = document.getElementById("keyboard"); var keyboard = document.getElementById("keyboard");
var fullscreenbutton = document.getElementById("fullscreenbutton"); var fullscreenbutton = document.getElementById("fullscreenbutton");
var text = document.getElementById("text"); var keyboardtext = document.getElementById("keyboardtext");
function showScene(scene) { function showScene(scene) {
[opening, closed, pad, keys, keyboard].forEach(function(element) { [opening, closed, pad, keys, keyboard].forEach(function(element) {
@ -349,32 +349,32 @@ window.addEventListener("load", function() {
}); });
} }
function showKeys(page_index) { function showKeys(pageIndex) {
if (page_index < 0 || keys_pages.length <= page_index) { if (!Number.isInteger(pageIndex) || pageIndex < 0 || keysPages.length <= pageIndex) {
page_index = 0; pageIndex = 0;
} }
exitFullscreen(); exitFullscreen();
showScene(keys); showScene(keys);
for (var i = 0; i < keys_pages.length; i += 1) { for (var i = 0; i < keysPages.length; i += 1) {
keys_pages[i].classList.toggle("hidden", i != page_index); keysPages[i].classList.toggle("hidden", i != pageIndex);
} }
if ((history.state || "").split(":")[0] == "keys") { if ((history.state || "").split(":")[0] == "keys") {
history.replaceState("keys:" + page_index, ""); history.replaceState("keys:" + pageIndex, "");
} else { } else {
history.pushState("keys:" + page_index, ""); history.pushState("keys:" + pageIndex, "");
} }
} }
function showKeyboard() { function showKeyboard() {
exitFullscreen(); exitFullscreen();
showScene(keyboard); showScene(keyboard);
text.focus(); keyboardtext.focus();
if (history.state != "keyboard") { if (history.state != "keyboard") {
history.pushState("keyboard", ""); history.pushState("keyboard", "");
} }
} }
text.value = ""; keyboardtext.value = "";
showScene(opening); showScene(opening);
var wsURL = new URL("ws", location.href); var wsURL = new URL("ws", location.href);
@ -414,13 +414,13 @@ window.addEventListener("load", function() {
} }
}); });
document.getElementById("switchbutton").addEventListener("click", function() { document.getElementById("switchbutton").addEventListener("click", function() {
var page_index = 0; var pageIndex = 0;
for (var i = 0; i < keys_pages.length; i += 1) { for (var i = 0; i < keysPages.length; i += 1) {
if (!keys_pages[i].classList.contains("hidden")) { if (!keysPages[i].classList.contains("hidden")) {
page_index = i; pageIndex = i;
} }
} }
showKeys(page_index + 1); showKeys(pageIndex + 1);
}); });
[ [
{id: "browserbackbutton", key: KEY_BROWSER_BACK}, {id: "browserbackbutton", key: KEY_BROWSER_BACK},
@ -440,19 +440,19 @@ window.addEventListener("load", function() {
{id: "leftbutton", key: KEY_LEFT}, {id: "leftbutton", key: KEY_LEFT},
{id: "rightbutton", key: KEY_RIGHT}, {id: "rightbutton", key: KEY_RIGHT},
{id: "upbutton", key: KEY_UP}, {id: "upbutton", key: KEY_UP},
{id: "downbutton", key: KEY_DOWN}, {id: "downbutton", key: KEY_DOWN}
].forEach(function(o) { ].forEach(function(o) {
document.getElementById(o.id).addEventListener("click", function() { document.getElementById(o.id).addEventListener("click", function() {
ws.send("k" + o.key); ws.send("k" + o.key);
}); });
}); });
document.getElementById("textkeysbutton").addEventListener("click", function() { document.getElementById("keyboardkeysbutton").addEventListener("click", function() {
showKeys(1); showKeys(1);
}); });
document.getElementById("sendbutton").addEventListener("click", function() { document.getElementById("sendbutton").addEventListener("click", function() {
if (text.value != "") { if (keyboardtext.value) {
ws.send("t" + text.value); ws.send("t" + keyboardtext.value);
text.value = ""; keyboardtext.value = "";
} }
window.history.back(); window.history.back();
}); });

View file

@ -24,9 +24,9 @@
<button id="keyboardbutton"></button> <button id="keyboardbutton"></button>
</div> </div>
<div id="keyboard" class="hidden"> <div id="keyboard" class="hidden">
<textarea id="text" cols=1 rows=1></textarea> <textarea id="keyboardtext" cols=1 rows=1></textarea>
<div class="buttons"> <div class="buttons">
<button id="textkeysbutton"></button> <button id="keyboardkeysbutton"></button>
<button id="sendbutton"></button> <button id="sendbutton"></button>
</div> </div>
</div> </div>